Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused settings.php and settings.acquia.php #215

Merged
merged 10 commits into from
Jul 13, 2023

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Jan 28, 2023

These files were leftover from when the-build was using templated settings.*.php files. AFAIK, they are currently not used or installed into projects by the-build.

Testing

@byrond byrond requested a review from becw January 28, 2023 00:59
@byrond byrond self-assigned this Jan 28, 2023
@agentrickard
Copy link
Contributor

Not a test fail, but worth looking at:

Drupal URI [] :      [phing] /home/circleci/example/vendor/palantirnet/the-build/targets/install.xml:13:34: Unable to find build file: /home/circleci/example/the-build.xml
 

@byrond
Copy link
Contributor Author

byrond commented Jun 23, 2023

Well, adding ${phing.dir.install} allowed the file to be found, but that uncovered another error. I think the Platform.sh issue should have been fixed another way:
#155

I'll add a ticket to revisit that.

@agentrickard

@becw
Copy link
Member

becw commented Jul 13, 2023

The failing check is unrelated to this PR. I'm going to merge!

@becw becw merged commit ae9dc96 into develop Jul 13, 2023
@becw becw deleted the remove-old-settings-php branch July 13, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants